agavra commented on issue #10140: URL: https://github.com/apache/pinot/issues/10140#issuecomment-1387335390
I think we might want to make `onDataAvailable` non-blocking (e.g. doesn't go through `_monitor`). That makes it much more complicated and error prone for the implementation (e.g. `_seenMail` in `RoundRobinScheduler` needs to handle concurrent read/writes). Separately, we should also see if we can bound the GRPC worker threads (cc @61yao as well since you've been looking into improving the way we use GRPC) - I don't think there's ever a good reason to have that many of them. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For additional commands, e-mail: commits-h...@pinot.apache.org
