walterddr commented on code in PR #10120:
URL: https://github.com/apache/pinot/pull/10120#discussion_r1068906614
##########
pinot-common/src/main/java/org/apache/pinot/common/datablock/BaseDataBlock.java:
##########
@@ -27,6 +27,7 @@
import java.util.HashMap;
import java.util.Map;
import javax.annotation.Nullable;
+import org.apache.pinot.common.datatable.DataTable;
Review Comment:
nit: we can copy the impl over. in fact we were deliberately decoupling data
table from data block.
##########
pinot-query-runtime/src/test/resources/queries/Skew.json:
##########
@@ -0,0 +1,31 @@
+{
+ "skew": {
+ "tables": {
+ "tbl": {
+ "schema": [
+ {"name": "key", "type": "STRING"},
+ {"name": "val", "type": "INT"}
+ ],
+ "inputs": [
+ ["a", 1],
+ ["a", 2],
+ ["a", 3],
+ ["a", 4],
+ ["a", 4],
+ ["a", 4],
+ ["a", 7],
+ ["a", 9]
Review Comment:
can you add a partition key and assign them to different server using
partition key but not the group by key, for example:
```
["a", "key1", 1]
["a", "key2", 2]
["a", "key3", 4]
["a", "key4", 6]
["b", "key2", 1]
["b", "key4", 7]
["b", "key3", 9]
```
I felt like we are missing an intermediate aggregation that needs to deal
with after-shuffle results
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
