[GitHub] [pinot] zhtaoxiang commented on a diff in pull request #10104: fix java doc in AbstractMetrics

[GitBox]

zhtaoxiang commented on code in PR #10104:
URL: https://github.com/apache/pinot/pull/10104#discussion_r1068821591


##########
pinot-common/src/main/java/org/apache/pinot/common/metrics/AbstractMetrics.java:
##########
@@ -707,15 +708,16 @@ public void removeTableGauge(final String tableName, 
final G gauge) {
 
 
   /**
+   * @deprecated please use removeTableGauge(final String tableName, final 
String key, final G gauge) instead
+   *
    * Removes a table gauge given the table name and the gauge.
    * The add/remove is expected to work correctly in case of being invoked 
across multiple threads.
    * @param tableName table name
+   * @param partitionId The partition id
    * @param gauge the gauge to be removed
    */
   public void removePartitionGauge(final String tableName, final int 
partitionId, final G gauge) {

Review Comment:
   I have updated the functions, and here is the metric emitted. The metric 
still works.
   
   <img width="877" alt="Screenshot 2023-01-12 at 5 03 05 PM" 
src="https://user-images.githubusercontent.com/9796617/212214164-26d79497-8020-4e2d-bc6a-61762f307789.png";>
   
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org