ankitsultana commented on code in PR #10099:
URL: https://github.com/apache/pinot/pull/10099#discussion_r1067820183
##########
pinot-query-runtime/src/main/java/org/apache/pinot/query/mailbox/channel/MailboxContentStreamObserver.java:
##########
@@ -132,6 +158,8 @@ public void onNext(Mailbox.MailboxContent mailboxContent) {
}
_gotMailCallback.accept(_mailboxId);
+ updateMaxBufferSize();
Review Comment:
What's the `_maxBufferSize` used for? Is it only for debugging.
##########
pinot-query-runtime/src/main/java/org/apache/pinot/query/mailbox/channel/MailboxContentStreamObserver.java:
##########
@@ -132,6 +158,8 @@ public void onNext(Mailbox.MailboxContent mailboxContent) {
}
_gotMailCallback.accept(_mailboxId);
+ updateMaxBufferSize();
+
if (_isEnabledFeedback) {
Review Comment:
side-note: do you know what's the goal of `isEnabledFeedback`? I think it's
always set to false right now.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
