Jackie-Jiang commented on code in PR #10101:
URL: https://github.com/apache/pinot/pull/10101#discussion_r1067510666
##########
pinot-core/src/main/java/org/apache/pinot/core/data/manager/realtime/IngestionDelayTracker.java:
##########
@@ -156,15 +142,15 @@ public IngestionDelayTracker(ServerMetrics serverMetrics,
String tableNameWithTy
*
* @param currentDelay original sample delay to which we will add the age of
the measure.
*/
- private long getAgedDelay(DelayMeasure currentDelay) {
- if (currentDelay == null) {
+ private long getAgedDelay(Long ingestionTimeMs) {
Review Comment:
Update the comments and method name accordingly, same for other places
##########
pinot-core/src/main/java/org/apache/pinot/core/data/manager/realtime/LLRealtimeSegmentDataManager.java:
##########
@@ -618,7 +618,7 @@ private boolean processStreamEvents(MessageBatch
messagesAndOffsets, long idlePi
_segmentLogger.debug("empty batch received - sleeping for {}ms",
idlePipeSleepTimeMillis);
}
// Record Pinot ingestion delay as zero since we are up-to-date and no
new events
- _realtimeTableDataManager.updateIngestionDelay(0,
System.currentTimeMillis(), _partitionGroupId);
+ _realtimeTableDataManager.updateIngestionDelay(0, _partitionGroupId);
Review Comment:
Should this be:
```suggestion
_realtimeTableDataManager.updateIngestionDelay(System.currentTimeMillis(),
_partitionGroupId);
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
