ankitsultana opened a new pull request, #10059: URL: https://github.com/apache/pinot/pull/10059
In this [PR](https://github.com/apache/pinot/pull/10001) the configs looked like so: ``` controller.http.server.thread.pool.corePoolSize: 10 controller.http.server.thread.pool.maxPoolSize: 10 broker.http.server.thread.pool.corePoolSize: 10 ... ``` This PR changes them to: ``` pinot.controller.http.server.thread.pool.corePoolSize: 10 pinot.controller.http.server.thread.pool.maxPoolSize: 10 pinot.broker.http.server.thread.pool.corePoolSize: 10 ... ``` At present soem configs have the pinot. prefix and some don't. Going forward we can try to ensure all configs have a pinot prefix to keep things consistent. **Test-Plan:** Tested on local for controller and broker by starting them with custom configs that set the pool size to 7, and then taking a thread-dump. Example: ``` $ export JAVA_OPTS="-Xms4G -Xmx4G -XX:+UseG1GC -XX:MaxGCPauseMillis=200 -Xloggc:gc-pinot-broker.log" ./bin/pinot-admin.sh StartBroker \ -zkAddress localhost:2191 -brokerConf conf/pinot-broker.conf ... $ jstack 22682 | grep grizzly-http | wc -l 7 ``` cc: @Jackie-Jiang -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For additional commands, e-mail: commits-h...@pinot.apache.org
