bobby-richard commented on code in PR #10045:
URL: https://github.com/apache/pinot/pull/10045#discussion_r1061421013
##########
pinot-connectors/pinot-flink-connector/src/main/java/org/apache/pinot/connector/flink/sink/PinotSinkFunction.java:
##########
@@ -96,7 +102,7 @@ public void close()
throws Exception {
LOG.info("Closing Pinot Sink");
try {
- if (_segmentNumRecord > 0) {
+ if (!((StreamingRuntimeContext)
this.getRuntimeContext()).isCheckpointingEnabled()) {
Review Comment:
ah yes, but only if checkpointing is enabled right? Otherwise the segment
will flush when the jobs fails
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
