siddharthteotia commented on code in PR #10042:
URL: https://github.com/apache/pinot/pull/10042#discussion_r1061004759
##########
pinot-core/src/main/java/org/apache/pinot/core/transport/QueryRouter.java:
##########
@@ -106,6 +116,12 @@ public AsyncQueryResponse submitQuery(long requestId,
String rawTableName,
}
if (realtimeBrokerRequest != null) {
assert realtimeRoutingTable != null;
+
+ if (realtimeBrokerRequest.pinotQuery.limit > 0) {
+ limitClausePresent = true;
+ limit += realtimeBrokerRequest.pinotQuery.limit;
Review Comment:
This logic will lead to incorrect results imo. Also, you need to do this
specifically for some queries.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
