ankitsultana commented on code in PR #10022:
URL: https://github.com/apache/pinot/pull/10022#discussion_r1055673967
##########
pinot-common/src/main/java/org/apache/pinot/common/metrics/AbstractMetrics.java:
##########
@@ -254,7 +254,8 @@ public void addValueToTableGauge(final String tableName,
final G gauge, final lo
String gaugeName = gauge.getGaugeName();
fullGaugeName = gaugeName + "." + getTableName(tableName);
- if (!_gaugeValues.containsKey(fullGaugeName)) {
Review Comment:
I believe it could cause perf issues. That's why the current code is also
doing a double-checked lock.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
