siddharthteotia commented on code in PR #9810:
URL: https://github.com/apache/pinot/pull/9810#discussion_r1043809372
##########
pinot-core/src/test/java/org/apache/pinot/queries/ForwardIndexDisabledSingleValueQueriesTest.java:
##########
@@ -845,6 +845,69 @@ public void testSelectQueriesWithReload()
assertEquals(resultRow[0], 240528);
assertEquals(resultRow[1], "gFuH");
}
+
+ // Re-enable forward index for column9, column11, and column6
Review Comment:
Can we add a test for a simple `SELECT *` or `SELECT reenabledColumn FROM
Foo LIMIT <MAX> ORDER BY <something>` .
Basically no WHERE clause.
This will have to read the entire forward index and can be a good
correctness test that entire forward index was generated correctly.
Something like
- Generate proper regular segment that has forward index.
- Gather resultSet1
- Disable forward index on a particular column via the reload path
- Query should fail
- Rebuild forward index via the reload path
- Gather resultSet2
resultSet1 should be same as resultSet2
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
