walterddr commented on code in PR #9895:
URL: https://github.com/apache/pinot/pull/9895#discussion_r1042903441
##########
pinot-query-runtime/src/test/resources/queries/FromExpressions.json:
##########
@@ -57,9 +57,14 @@
},
{
"psql": "7.2.1.1",
- "ignored": true,
+ "comments": "select all doesn't work because h2 output the rows in
different order from Pinot and test framework doesn't consider the column order
for rows and blindly assume they are in the same order",
"description": "RIGHT OUTER JOIN",
- "sql": "SELECT * FROM {tbl1} RIGHT OUTER JOIN {tbl2} ON {tbl1}.col1 =
{tbl2}.col1"
+ "sql": "SELECT {tbl1}.num, {tbl1}.name, {tbl2}.num, {tbl2}.value FROM
{tbl1} RIGHT OUTER JOIN {tbl2} ON {tbl1}.num = {tbl2}.num"
Review Comment:
could you add tests
1. with inequality conditions?
2. with mixed column selections such as `{tbl1}.num, {tbl2}.num,
{tbl1}.name, {tbl2}.value`
3. with mixed transform functions `{tbl1}.num > {tbl2}.num} + 1`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
