vvivekiyer commented on code in PR #9875:
URL: https://github.com/apache/pinot/pull/9875#discussion_r1042899409
##########
pinot-integration-tests/src/test/java/org/apache/pinot/integration/tests/LLCRealtimeClusterIntegrationTest.java:
##########
@@ -277,6 +277,48 @@ public void testReload()
testReload(false);
}
+ @Test
+ public void testEnableDisableDictionaryWithReload()
+ throws Exception {
+ String query = "SELECT * FROM myTable WHERE ActualElapsedTime > 0";
+ JsonNode queryResponse = postQuery(query);
+ long numTotalDocs = queryResponse.get("totalDocs").asLong();
+
+ // Enable dictionary.
+ TableConfig tableConfig = getRealtimeTableConfig();
+
tableConfig.getIndexingConfig().getNoDictionaryColumns().remove("ActualElapsedTime");
+ updateTableConfig(tableConfig);
+ String enableDictReloadId = reloadTableAndValidateResponse(getTableName(),
TableType.REALTIME, false);
+ TestUtils.waitForCondition(aVoid -> {
+ try {
+ return isReloadJobCompleted(enableDictReloadId);
+ } catch (Exception e) {
+ throw new RuntimeException(e);
+ }
+ }, 60_000L, "Failed to reload.");
+
+ queryResponse = postQuery(query);
+ long numTotalDocsAfterReload = queryResponse.get("totalDocs").asLong();
+ assertEquals(numTotalDocs, numTotalDocsAfterReload);
Review Comment:
Oh good point. Added this test.
Just want to mention I enabled both dictionary and inverted index because
"docs scanned in filter" is zero only if inverted index is added.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
