jackjlli commented on PR #9905: URL: https://github.com/apache/pinot/pull/9905#issuecomment-1340209523
> Seems it is within the parallel push protection, where only one thread should be able to push the segment. Let me explain a bit here. Yes, there should be only one thread that pushes the segment on the client side. While it could happen that the 1st attempt spends too much time (e.g. due to slow access to PinotFS) on uploading segment, which made the thread gave up its 1st attempt and retry the segment upload (2nd attempt), and the 2nd attempt succeeded. When the 1st attempt finally finished its work, it turned out that it failed to update the ZK metadata any more. Since the client side has already given up the 1st attempt (which leads to the 2nd attempt), the 1st segment upload shouldn't blindly delete the segment. Instead, the 1st controller should validate the crc one more time, and if crc remains the same, segment deletion should be skipped. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For additional commands, e-mail: commits-h...@pinot.apache.org
