61yao commented on PR #9895: URL: https://github.com/apache/pinot/pull/9895#issuecomment-1335825931
> > > WDYT about implementing this as a rewriter that just swaps the left and right tables? > > > > > > That's a good idea. but then we need to deal the situation where we output the rows in the right column order. Let me check the code to see how complicated it is > > I can probably write a calcite rule to do that I guess. I check that calcite doesn't have builtin rule for this. I tried to code the re-write and seems it is not very easy to do: https://github.com/apache/pinot/pull/9903/files Calcite will throw exception on transform call when we changed the join type I didn't update the inequi join condition (join.condition) in 9903 PR. but we have to solve the exception problem first. So I'll stick to this PR's method for now. @agavra -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For additional commands, e-mail: commits-h...@pinot.apache.org
