agavra commented on code in PR #9901:
URL: https://github.com/apache/pinot/pull/9901#discussion_r1038415383
##########
pinot-common/src/main/java/org/apache/pinot/common/function/scalar/StringFunctions.java:
##########
@@ -119,6 +131,17 @@ public static String concat(String input1, String input2,
String seperator) {
return result;
}
+ /**
+ * Join two input string with no seperator in between
+ * @param input1
+ * @param input2
+ * @return The two input strings joined
+ */
+ @ScalarFunction
+ public static String concat(String input1, String input2) {
+ return concat(input1, input2, "");
+ }
Review Comment:
we can't because it has the same type signature as the existing concat,
which has incorrect behavior (e.g. `concat(String, String, String)` already
treats the third string as the delimiter)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
