walterddr commented on code in PR #9850: URL: https://github.com/apache/pinot/pull/9850#discussion_r1038292605
########## pinot-query-runtime/src/test/resources/queries/Comparisons.json: ########## @@ -390,6 +390,7 @@ "queries": [ { "sql": "SELECT val BETWEEN small AND big FROM {tbl}" }, { "sql": "SELECT val BETWEEN big AND small FROM {tbl}" }, + { "sql": "SELECT val BETWEEN 2 AND 3 FROM {tbl}" }, Review Comment: - add another test for `BETWEEN 3 AND 2`; literal values actually will be optimized out. - add NOT BETWEEN variance as well -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For additional commands, e-mail: commits-h...@pinot.apache.org