[GitHub] [pinot] snleee commented on a diff in pull request #9849: Combine the read access for replication config

[GitBox]

snleee commented on code in PR #9849:
URL: https://github.com/apache/pinot/pull/9849#discussion_r1031028143


##########
pinot-controller/src/main/java/org/apache/pinot/controller/api/resources/PinotTableRestletResource.java:
##########
@@ -813,7 +813,7 @@ public String getTableAggregateMetadata(
     TableConfig tableConfig = 
_pinotHelixResourceManager.getTableConfig(tableNameWithType);
     SegmentsValidationAndRetentionConfig segmentsConfig =

Review Comment:
   removed



##########
pinot-controller/src/main/java/org/apache/pinot/controller/api/resources/PinotTableRestletResource.java:
##########
@@ -813,7 +813,7 @@ public String getTableAggregateMetadata(
     TableConfig tableConfig = 
_pinotHelixResourceManager.getTableConfig(tableNameWithType);
     SegmentsValidationAndRetentionConfig segmentsConfig =
         tableConfig != null ? tableConfig.getValidationConfig() : null;
-    int numReplica = segmentsConfig == null ? 1 : 
Integer.parseInt(segmentsConfig.getReplication());
+    int numReplica = segmentsConfig == null ? 1 : 
tableConfig.getReplicationNumber();

Review Comment:
   fixed



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org