61yao commented on code in PR #9832:
URL: https://github.com/apache/pinot/pull/9832#discussion_r1029934624
##########
pinot-query-runtime/src/test/resources/queries/OrderBy.json:
##########
@@ -0,0 +1,221 @@
+{
+ "basic_order_by": {
+ "tables": {
+ "basic": {
+ "schema": [
+ {"name": "col0", "type": "INT"},
+ {"name": "col1", "type": "INT"},
+ {"name": "col2", "type": "STRING"}
+ ],
+ "inputs": [
+ [1, 2, "a"],
+ [2, 3, "b"],
+ [3, 1, "c"],
+ [4, 4, "d"],
+ [5, 5, "e"],
+ [6, 6, "f"]
+ ]
+ }
+ },
+ "queries": [
+ {"sql": "SELECT * FROM {basic} ORDER BY col1 LIMIT 2 OFFSET 1"},
Review Comment:
Can we add a test for offest 0, offset 100, limit 100 and Limit all (psql
supports this). as well as limit null statement
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
