gortiz commented on PR #9842: URL: https://github.com/apache/pinot/pull/9842#issuecomment-1323953675
This first commit is a draft. Tests need to be extended to cover the new implementation and I would also add at least one benchmark to verify that there is no performance degradation. It would also be great to add some verification that with this change Pinot will be able to run with Java 17. Also, writing the code I've seen some places where the buffers are being use and there may be better implementations, but I would also need to benchmark the alternative to be sure (and this can be done in another PR) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For additional commands, e-mail: commits-h...@pinot.apache.org
