61yao opened a new pull request, #9836: URL: https://github.com/apache/pinot/pull/9836
This PR moves sending mailbox map from global map (MailboxService) to per request context (PlanRequestContext). The old design has two issues: 1) Memory leak of the instance because when request finishes, the sending mailbox doesn't need to be alive anymore (this is also true for receiving mailbox) 2) High contention for the concurrent hash map. The new implementation moves the instance and exchange to per request context. 1) This fixes the memory leak and contention issue for the old design. 2) This opens the door for better resource cleaning and error handling in general. Following PRs would be: 1) proper close mailbox channel and propagate error when there is an error 2) clean up the leak for receiving mailbox (same issue) 3) Have a better abstraction for request context. (should be runtime context or opchain context) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For additional commands, e-mail: commits-h...@pinot.apache.org
