walterddr commented on code in PR #9821:
URL: https://github.com/apache/pinot/pull/9821#discussion_r1025900679
##########
pinot-query-runtime/src/test/resources/queries/Comparisons.json:
##########
@@ -0,0 +1,516 @@
+{
+ "ints_comp": {
+ "psql": "9.2",
+ "tables": {
+ "tbl": {
+ "schema": [
+ {"name": "i1", "type": "INT"},
+ {"name": "i2", "type": "INT"}
+ ],
+ "inputs": [
+ [1, 2], [1, 1], [-1, -2], [0, 0], [2147483647, -2147483648]
+ ]
+ }
+ },
+ "queries": [
+ { "sql": "SELECT i1 < i2, i2 < i1 FROM {tbl}" },
+ { "sql": "SELECT i1 <= i2, i2 <= i1 FROM {tbl}" },
+ { "sql": "SELECT i1 > i2, i2 > i1 FROM {tbl}" },
+ { "sql": "SELECT i1 >= i2, i2 >= i1 FROM {tbl}" },
+ { "sql": "SELECT i1 != i2, i2 != i1 FROM {tbl}" },
+ { "sql": "SELECT i1 <> i2, i2 <> i1 FROM {tbl}" },
+ { "sql": "SELECT i1 = i2, i2 = i1 FROM {tbl}" },
+ { "sql": "SELECT i1 IS DISTINCT FROM i2, i2 IS DISTINCT FROM i1 FROM
{tbl}" },
+ { "sql": "SELECT * FROM {tbl} WHERE i1 >= i2" }
+ ]
+ },
+ "boolean_comp": {
+ "psql": "9.2",
+ "tables": {
+ "tbl": {
+ "schema": [
+ {"name": "i1", "type": "BOOLEAN"},
+ {"name": "i2", "type": "BOOLEAN"}
+ ],
+ "inputs": [
+ [true, true], [true, false], [false, true], [false, false]
+ ]
+ }
+ },
+ "queries": [
+ { "sql": "SELECT i1 < i2, i2 < i1 FROM {tbl}" },
+ { "sql": "SELECT i1 <= i2, i2 <= i1 FROM {tbl}" },
+ { "sql": "SELECT i1 > i2, i2 > i1 FROM {tbl}" },
+ { "sql": "SELECT i1 >= i2, i2 >= i1 FROM {tbl}" },
+ { "sql": "SELECT i1 != i2, i2 != i1 FROM {tbl}" },
+ { "sql": "SELECT i1 <> i2, i2 <> i1 FROM {tbl}" },
+ { "sql": "SELECT i1 = i2, i2 = i1 FROM {tbl}" },
+ { "sql": "SELECT i1 IS DISTINCT FROM i2, i2 IS DISTINCT FROM i1 FROM
{tbl}" },
+ { "sql": "SELECT * FROM {tbl} WHERE i1 >= i2" }
+ ]
+ },
+ "floats_comp": {
+ "psql": "9.2",
+ "tables": {
+ "tbl": {
+ "schema": [
+ {"name": "i1", "type": "FLOAT"},
+ {"name": "i2", "type": "FLOAT"}
+ ],
+ "inputs": [
+ [1.1, 1.2], [1.01, 1.1], [1.1, 1.1], [-1.1, -1.2], [0.0, 0.0],
[1E-37, 1E+37]
+ ]
+ }
+ },
+ "queries": [
+ { "sql": "SELECT i1 < i2, i2 < i1 FROM {tbl}" },
+ { "sql": "SELECT i1 <= i2, i2 <= i1 FROM {tbl}" },
+ { "sql": "SELECT i1 > i2, i2 > i1 FROM {tbl}" },
+ { "sql": "SELECT i1 >= i2, i2 >= i1 FROM {tbl}" },
+ { "sql": "SELECT i1 != i2, i2 != i1 FROM {tbl}" },
+ { "sql": "SELECT i1 <> i2, i2 <> i1 FROM {tbl}" },
+ { "sql": "SELECT i1 = i2, i2 = i1 FROM {tbl}" },
+ { "sql": "SELECT i1 IS DISTINCT FROM i2, i2 IS DISTINCT FROM i1 FROM
{tbl}" },
+ { "sql": "SELECT * FROM {tbl} WHERE i1 >= i2" }
+ ]
+ },
+ "doubles_comp": {
+ "psql": "9.2",
+ "tables": {
+ "tbl": {
+ "schema": [
+ {"name": "i1", "type": "DOUBLE"},
+ {"name": "i2", "type": "DOUBLE"}
+ ],
+ "inputs": [
+ [1.1, 1.2], [1.01, 1.1], [1.1, 1.1], [-1.1, -1.2], [0.0, 0.0],
[1E-307, 1E+307]
+ ]
+ }
+ },
+ "queries": [
+ { "sql": "SELECT i1 < i2, i2 < i1 FROM {tbl}" },
+ { "sql": "SELECT i1 <= i2, i2 <= i1 FROM {tbl}" },
+ { "sql": "SELECT i1 > i2, i2 > i1 FROM {tbl}" },
+ { "sql": "SELECT i1 >= i2, i2 >= i1 FROM {tbl}" },
+ { "sql": "SELECT i1 != i2, i2 != i1 FROM {tbl}" },
+ { "sql": "SELECT i1 <> i2, i2 <> i1 FROM {tbl}" },
+ { "sql": "SELECT i1 = i2, i2 = i1 FROM {tbl}" },
+ { "sql": "SELECT i1 IS DISTINCT FROM i2, i2 IS DISTINCT FROM i1 FROM
{tbl}" },
+ { "sql": "SELECT * FROM {tbl} WHERE i1 >= i2" }
+ ]
+ },
+ "numerics_comp": {
+ "psql": "9.2",
+ "tables": {
+ "tbl": {
+ "schema": [
+ {"name": "i1", "type": "BIG_DECIMAL"},
+ {"name": "i2", "type": "BIG_DECIMAL"}
+ ],
+ "inputs": [
+ ["1.1", "1.2"], ["1.01", "1.1"], ["1.1", "1.1"], ["-1.1", "-1.2"],
["0.0", "0.0"], ["1E-307", "1E+307"]
+ ]
+ }
+ },
+ "queries": [
+ { "sql": "SELECT i1 < i2, i2 < i1 FROM {tbl}" },
+ { "sql": "SELECT i1 <= i2, i2 <= i1 FROM {tbl}" },
+ { "sql": "SELECT i1 > i2, i2 > i1 FROM {tbl}" },
+ { "sql": "SELECT i1 >= i2, i2 >= i1 FROM {tbl}" },
+ { "sql": "SELECT i1 != i2, i2 != i1 FROM {tbl}" },
+ { "sql": "SELECT i1 <> i2, i2 <> i1 FROM {tbl}" },
+ { "sql": "SELECT i1 = i2, i2 = i1 FROM {tbl}" },
+ { "sql": "SELECT i1 IS DISTINCT FROM i2, i2 IS DISTINCT FROM i1 FROM
{tbl}" },
+ {
+ "ignored": true,
+ "comment": "fails with IllegalStateException... not sure why!",
+ "sql": "SELECT * FROM {tbl} WHERE i1 >= i2"
+ }
+ ]
+ },
+ "strings_comp": {
+ "psql": "9.2",
+ "tables": {
+ "tbl": {
+ "schema": [
+ {"name": "i1", "type": "STRING"},
+ {"name": "i2", "type": "STRING"}
+ ],
+ "inputs": [
+ ["foo", "foo"], ["foo", "bar"],
+ ["123", "123"], ["123", "321"],
+ ["alpha123", "alpha321"],
+ ["beta123", "gamma123"],
+ ["Οὐχὶ (greek)", "แสน (thai)"],
+ ["", ""],
+ ["", "foo"]
+ ]
+ }
+ },
+ "queries": [
+ { "sql": "SELECT i1 < i2, i2 < i1 FROM {tbl}" },
+ { "sql": "SELECT i1 <= i2, i2 <= i1 FROM {tbl}" },
+ { "sql": "SELECT i1 > i2, i2 > i1 FROM {tbl}" },
+ { "sql": "SELECT i1 >= i2, i2 >= i1 FROM {tbl}" },
+ { "sql": "SELECT i1 != i2, i2 != i1 FROM {tbl}" },
+ { "sql": "SELECT i1 <> i2, i2 <> i1 FROM {tbl}" },
+ { "sql": "SELECT i1 = i2, i2 = i1 FROM {tbl}" },
+ { "sql": "SELECT i1 IS DISTINCT FROM i2, i2 IS DISTINCT FROM i1 FROM
{tbl}" },
+ { "sql": "SELECT * FROM {tbl} WHERE i1 >= i2" }
+ ]
+ },
+ "timestamps_comp": {
+ "ignored": true,
+ "comment": "we don't support timestamp comparisons",
+ "psql": "9.2",
+ "tables": {
+ "tbl": {
+ "schema": [
+ {"name": "i1", "type": "TIMESTAMP"},
+ {"name": "i2", "type": "TIMESTAMP"}
+ ],
+ "inputs": [
+ ["2020-01-01 03:32:12", "2020-01-01 03:32:12"],
+ ["2020-01-01 03:32:12", "2020-02-01 03:32:12"]
+ ]
+ }
+ },
+ "queries": [
+ { "sql": "SELECT i1 < i2, i2 < i1 FROM {tbl}" },
+ { "sql": "SELECT i1 <= i2, i2 <= i1 FROM {tbl}" },
+ { "sql": "SELECT i1 > i2, i2 > i1 FROM {tbl}" },
+ { "sql": "SELECT i1 >= i2, i2 >= i1 FROM {tbl}" },
+ { "sql": "SELECT i1 != i2, i2 != i1 FROM {tbl}" },
+ { "sql": "SELECT i1 <> i2, i2 <> i1 FROM {tbl}" },
+ { "sql": "SELECT i1 = i2, i2 = i1 FROM {tbl}" },
+ { "sql": "SELECT i1 IS DISTINCT FROM i2, i2 IS DISTINCT FROM i1 FROM
{tbl}" },
+ { "sql": "SELECT * FROM {tbl} WHERE i1 >= i2" }
+ ]
+ },
+ "int_x_bigint_comp": {
+ "psql": "9.2",
+ "tables": {
+ "tbl": {
+ "schema": [
+ {"name": "i1", "type": "INT"},
+ {"name": "i2", "type": "LONG"}
+ ],
+ "inputs": [
+ [1, 2], [1, 1], [-1, -2], [0, 0], [2147483647, -2147483648]
+ ]
+ }
+ },
+ "queries": [
+ { "sql": "SELECT i1 < i2, i2 < i1 FROM {tbl}" },
+ { "sql": "SELECT i1 <= i2, i2 <= i1 FROM {tbl}" },
+ { "sql": "SELECT i1 > i2, i2 > i1 FROM {tbl}" },
+ { "sql": "SELECT i1 >= i2, i2 >= i1 FROM {tbl}" },
+ { "sql": "SELECT i1 != i2, i2 != i1 FROM {tbl}" },
+ { "sql": "SELECT i1 <> i2, i2 <> i1 FROM {tbl}" },
+ { "sql": "SELECT i1 = i2, i2 = i1 FROM {tbl}" },
+ { "sql": "SELECT i1 IS DISTINCT FROM i2, i2 IS DISTINCT FROM i1 FROM
{tbl}" }
+ ]
+ },
+ "int_x_float_comp": {
+ "psql": "9.2",
+ "tables": {
+ "tbl": {
+ "schema": [
+ {"name": "i1", "type": "INT"},
+ {"name": "i2", "type": "FLOAT"}
+ ],
+ "inputs": [
+ [1, 2.0], [1, 0.9], [-1, -2.0], [0, 0.0], [2147483647,
-2147483648.001]
+ ]
+ }
+ },
+ "queries": [
+ { "sql": "SELECT i1 < i2, i2 < i1 FROM {tbl}" },
+ { "sql": "SELECT i1 <= i2, i2 <= i1 FROM {tbl}" },
+ { "sql": "SELECT i1 > i2, i2 > i1 FROM {tbl}" },
+ { "sql": "SELECT i1 >= i2, i2 >= i1 FROM {tbl}" },
+ { "sql": "SELECT i1 != i2, i2 != i1 FROM {tbl}" },
+ { "sql": "SELECT i1 <> i2, i2 <> i1 FROM {tbl}" },
+ { "sql": "SELECT i1 = i2, i2 = i1 FROM {tbl}" },
+ { "sql": "SELECT i1 IS DISTINCT FROM i2, i2 IS DISTINCT FROM i1 FROM
{tbl}" }
+ ]
+ },
+ "int_x_double_comp": {
+ "psql": "9.2",
+ "tables": {
+ "tbl": {
+ "schema": [
+ {"name": "i1", "type": "INT"},
+ {"name": "i2", "type": "DOUBLE"}
+ ],
+ "inputs": [
+ [1, 2.0], [1, 0.9], [-1, -2.0], [0, 0.0], [2147483647,
-2147483648.001]
+ ]
+ }
+ },
+ "queries": [
+ { "sql": "SELECT i1 < i2, i2 < i1 FROM {tbl}" },
+ { "sql": "SELECT i1 <= i2, i2 <= i1 FROM {tbl}" },
+ { "sql": "SELECT i1 > i2, i2 > i1 FROM {tbl}" },
+ { "sql": "SELECT i1 >= i2, i2 >= i1 FROM {tbl}" },
+ { "sql": "SELECT i1 != i2, i2 != i1 FROM {tbl}" },
+ { "sql": "SELECT i1 <> i2, i2 <> i1 FROM {tbl}" },
+ { "sql": "SELECT i1 = i2, i2 = i1 FROM {tbl}" },
+ { "sql": "SELECT i1 IS DISTINCT FROM i2, i2 IS DISTINCT FROM i1 FROM
{tbl}" }
+ ]
+ },
+ "int_x_numeric_comp": {
+ "psql": "9.2",
+ "tables": {
+ "tbl": {
+ "schema": [
+ {"name": "i1", "type": "INT"},
+ {"name": "i2", "type": "BIG_DECIMAL"}
+ ],
+ "inputs": [
+ [1, "2.0"], [1, "0.9"], [-1, "-2.0"], [0, "0.0"], [2147483647,
"-2147483648"]
+ ]
+ }
+ },
+ "queries": [
+ { "sql": "SELECT i1 < i2, i2 < i1 FROM {tbl}" },
+ { "sql": "SELECT i1 <= i2, i2 <= i1 FROM {tbl}" },
+ { "sql": "SELECT i1 > i2, i2 > i1 FROM {tbl}" },
+ { "sql": "SELECT i1 >= i2, i2 >= i1 FROM {tbl}" },
+ { "sql": "SELECT i1 != i2, i2 != i1 FROM {tbl}" },
+ { "sql": "SELECT i1 <> i2, i2 <> i1 FROM {tbl}" },
+ { "sql": "SELECT i1 = i2, i2 = i1 FROM {tbl}" },
+ { "sql": "SELECT i1 IS DISTINCT FROM i2, i2 IS DISTINCT FROM i1 FROM
{tbl}" }
+ ]
+ },
+ "float_x_bigint_comp": {
+ "psql": "9.2",
+ "tables": {
+ "tbl": {
+ "schema": [
+ {"name": "i1", "type": "FLOAT"},
+ {"name": "i2", "type": "LONG"}
+ ],
+ "inputs": [
+ [1.1, 1], [0.01, 1], [1.1, 1], [-1.1, -1], [0.0, 0], [1E-37, 137]
+ ]
+ }
+ },
+ "queries": [
+ { "sql": "SELECT i1 < i2, i2 < i1 FROM {tbl}" },
+ { "sql": "SELECT i1 <= i2, i2 <= i1 FROM {tbl}" },
+ { "sql": "SELECT i1 > i2, i2 > i1 FROM {tbl}" },
+ { "sql": "SELECT i1 >= i2, i2 >= i1 FROM {tbl}" },
+ { "sql": "SELECT i1 != i2, i2 != i1 FROM {tbl}" },
+ { "sql": "SELECT i1 <> i2, i2 <> i1 FROM {tbl}" },
+ { "sql": "SELECT i1 = i2, i2 = i1 FROM {tbl}" },
+ { "sql": "SELECT i1 IS DISTINCT FROM i2, i2 IS DISTINCT FROM i1 FROM
{tbl}" }
+ ]
+ },
+ "float_x_double_comp": {
+ "psql": "9.2",
+ "tables": {
+ "tbl": {
+ "schema": [
+ {"name": "i1", "type": "FLOAT"},
+ {"name": "i2", "type": "DOUBLE"}
+ ],
+ "inputs": [
+ [1.1, 1.2],
+ [1.01, 1.1],
+ [1.1, 1.1],
+ [-1.1, -1.2],
+ [0.0, 0.0],
+ [1E-37, 1E+37]
+ ]
+ }
+ },
+ "queries": [
+ { "sql": "SELECT i1 < i2, i2 < i1 FROM {tbl}" },
+ { "sql": "SELECT i1 <= i2, i2 <= i1 FROM {tbl}" },
+ { "sql": "SELECT i1 > i2, i2 > i1 FROM {tbl}" },
+ { "sql": "SELECT i1 >= i2, i2 >= i1 FROM {tbl}" },
+ { "sql": "SELECT i1 IS DISTINCT FROM i2, i2 IS DISTINCT FROM i1 FROM
{tbl}" },
+ {
+ "ignored": true,
Review Comment:
this might be related to the type hoisting PR. i will test it and see if it
fixes this
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
