mayankshriv commented on code in PR #9777:
URL: https://github.com/apache/pinot/pull/9777#discussion_r1024369914
##########
pinot-segment-local/src/main/java/org/apache/pinot/segment/local/segment/index/loader/defaultcolumn/BaseDefaultColumnHandler.java:
##########
@@ -553,6 +554,16 @@ private void createDefaultValueColumnV1Indices(String
column)
}
}
+ if (!_segmentWriter.hasIndexFor(column, ColumnIndexType.NULLVALUE_VECTOR))
{
Review Comment:
Should the `nullValueVector` be created only when `nullHandlingEnabled` is
set to true?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
