walterddr commented on code in PR #9806:
URL: https://github.com/apache/pinot/pull/9806#discussion_r1024316851
##########
pinot-query-runtime/src/test/java/org/apache/pinot/query/runtime/QueryRunnerTestBase.java:
##########
@@ -151,6 +163,10 @@ protected void compareRowEquals(List<Object[]> resultRows,
List<Object[]> expect
Object[] resultRow = resultRows.get(i);
Object[] expectedRow = expectedRows.get(i);
for (int j = 0; j < resultRow.length; j++) {
+ if (j >= expectedRow.length) {
+ throw new AssertException(String.format("Unexpected row size
mismatch. Expected: %s, Actual: %s",
+ Arrays.toString(expectedRow), Arrays.toString(resultRow)));
+ }
Review Comment:
no need to check on every `j` right?
```suggestion
Assert.assertTrue(resultRow.length == expectedRow.length,
String.format("Unexpected row size mismatch. Expected: %s, Actual: %s",
Arrays.toString(expectedRow), Arrays.toString(resultRow)))
for (int j = 0; j < resultRow.length; j++) {
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
