61yao commented on code in PR #9778: URL: https://github.com/apache/pinot/pull/9778#discussion_r1022381315
########## pinot-query-planner/src/main/java/org/apache/calcite/rel/rules/PinotJoinExchangeNodeInsertRule.java: ########## @@ -65,6 +65,7 @@ public void onMatch(RelOptRuleCall call) { if (joinInfo.leftKeys.isEmpty()) { // when there's no JOIN key, use broadcast. + // TODO: Double check broadcast distribution won't cause problems Review Comment: I haven't figured out yet. Removed the comment for now -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For additional commands, e-mail: commits-h...@pinot.apache.org