walterddr commented on code in PR #9753:
URL: https://github.com/apache/pinot/pull/9753#discussion_r1019530377
##########
pinot-query-runtime/src/main/java/org/apache/pinot/query/runtime/executor/WorkerQueryExecutor.java:
##########
@@ -69,26 +65,12 @@ public synchronized void shutDown() {
}
public void processQuery(DistributedStagePlan queryRequest, Map<String,
String> requestMetadataMap,
- ExecutorService executorService) {
+ OpChainSchedulerService scheduler) {
Review Comment:
not necessarily needed in this PR: let's change this API to directly take
operator chain as input
```suggestion
public void processQuery(OpChain opChain, OpChainSchedulerService
scheduler) {
```
and make the opChain constructor outside --> this way we can early return if
there's any error during opChain construct
##########
pinot-query-runtime/src/main/java/org/apache/pinot/query/runtime/QueryRunner.java:
##########
@@ -128,7 +129,7 @@ public void processQuery(DistributedStagePlan
distributedStagePlan, ExecutorServ
for (ServerPlanRequestContext requestContext : serverQueryRequests) {
ServerQueryRequest request = new
ServerQueryRequest(requestContext.getInstanceRequest(),
new ServerMetrics(PinotMetricUtils.getPinotMetricsRegistry()),
System.currentTimeMillis());
- serverQueryResults.add(processServerQuery(request, executorService));
+ serverQueryResults.add(processServerQuery(request,
scheduler.getWorkerPool()));
Review Comment:
this means leaf stage are directly scheduled on top of the worker pool?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
