agavra commented on code in PR #9726: URL: https://github.com/apache/pinot/pull/9726#discussion_r1015994065
########## pinot-query-planner/src/test/java/org/apache/pinot/query/testutils/MockRoutingManagerFactory.java: ########## @@ -0,0 +1,145 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +package org.apache.pinot.query.testutils; + +import java.util.ArrayList; +import java.util.HashMap; +import java.util.List; +import java.util.Map; +import java.util.concurrent.TimeUnit; +import org.apache.pinot.common.config.provider.TableCache; +import org.apache.pinot.common.request.BrokerRequest; +import org.apache.pinot.core.routing.RoutingManager; +import org.apache.pinot.core.routing.RoutingTable; +import org.apache.pinot.core.routing.TimeBoundaryInfo; +import org.apache.pinot.core.transport.ServerInstance; +import org.apache.pinot.query.routing.WorkerInstance; +import org.apache.pinot.spi.config.table.TableType; +import org.apache.pinot.spi.data.Schema; +import org.apache.pinot.spi.utils.builder.TableNameBuilder; + +import static org.mockito.ArgumentMatchers.any; +import static org.mockito.ArgumentMatchers.anyString; +import static org.mockito.Mockito.mock; +import static org.mockito.Mockito.when; + + +/** + * This is a builder pattern for generating a Mock Routing Manager. + */ +public class MockRoutingManagerFactory { + private static final String TIME_BOUNDARY_COLUMN = "ts"; + private static final String HOST_NAME = "localhost"; + + private final HashMap<String, String> _tableNameMap; + private final Map<String, Schema> _schemaMap; + + private final Map<String, ServerInstance> _serverInstances; + private final Map<String, RoutingTable> _mockRoutingTableMap; + private final List<String> _hybridTables; + + private final Map<String, Map<ServerInstance, List<String>>> _tableServerSegmentMap; + + public MockRoutingManagerFactory(int... ports) { + _hybridTables = new ArrayList<>(); + _serverInstances = new HashMap<>(); + _schemaMap = new HashMap<>(); + _tableNameMap = new HashMap<>(); + _mockRoutingTableMap = new HashMap<>(); + + _tableServerSegmentMap = new HashMap<>(); + for (int port : ports) { + _serverInstances.put(toHostname(port), new WorkerInstance(HOST_NAME, port, port, port, port)); + } + } + + public MockRoutingManagerFactory registerTable(Schema schema, String tableName) { + TableType tableType = TableNameBuilder.getTableTypeFromTableName(tableName); + if (tableType == null) { + registerTableNameWithType(schema, TableNameBuilder.forType(TableType.OFFLINE).tableNameWithType(tableName)); + registerTableNameWithType(schema, TableNameBuilder.forType(TableType.REALTIME).tableNameWithType(tableName)); + _hybridTables.add(tableName); + } else { + registerTableNameWithType(schema, TableNameBuilder.forType(tableType).tableNameWithType(tableName)); + } + return this; + } + + public MockRoutingManagerFactory registerSegment(int insertToServerPort, String tableNameWithType, + String segmentName) { + Map<ServerInstance, List<String>> serverSegmentMap = + _tableServerSegmentMap.getOrDefault(tableNameWithType, new HashMap<>()); + ServerInstance serverInstance = _serverInstances.get(toHostname(insertToServerPort)); + + List<String> sSegments = serverSegmentMap.getOrDefault(serverInstance, new ArrayList<>()); + sSegments.add(segmentName); + serverSegmentMap.put(serverInstance, sSegments); + _tableServerSegmentMap.put(tableNameWithType, serverSegmentMap); + return this; + } + + public RoutingManager buildRoutingManager() { + // create all the mock routing tables + _mockRoutingTableMap.clear(); + for (Map.Entry<String, Map<ServerInstance, List<String>>> tableEntry : _tableServerSegmentMap.entrySet()) { + String tableNameWithType = tableEntry.getKey(); + RoutingTable mockRoutingTable = mock(RoutingTable.class); Review Comment: nit: feels like we should just create a real routing table instead of mocking it - it's a basic container class ########## pinot-query-planner/src/test/java/org/apache/pinot/query/testutils/MockRoutingManagerFactory.java: ########## @@ -0,0 +1,145 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +package org.apache.pinot.query.testutils; + +import java.util.ArrayList; +import java.util.HashMap; +import java.util.List; +import java.util.Map; +import java.util.concurrent.TimeUnit; +import org.apache.pinot.common.config.provider.TableCache; +import org.apache.pinot.common.request.BrokerRequest; +import org.apache.pinot.core.routing.RoutingManager; +import org.apache.pinot.core.routing.RoutingTable; +import org.apache.pinot.core.routing.TimeBoundaryInfo; +import org.apache.pinot.core.transport.ServerInstance; +import org.apache.pinot.query.routing.WorkerInstance; +import org.apache.pinot.spi.config.table.TableType; +import org.apache.pinot.spi.data.Schema; +import org.apache.pinot.spi.utils.builder.TableNameBuilder; + +import static org.mockito.ArgumentMatchers.any; +import static org.mockito.ArgumentMatchers.anyString; +import static org.mockito.Mockito.mock; +import static org.mockito.Mockito.when; + + +/** + * This is a builder pattern for generating a Mock Routing Manager. + */ +public class MockRoutingManagerFactory { + private static final String TIME_BOUNDARY_COLUMN = "ts"; + private static final String HOST_NAME = "localhost"; + + private final HashMap<String, String> _tableNameMap; + private final Map<String, Schema> _schemaMap; + + private final Map<String, ServerInstance> _serverInstances; + private final Map<String, RoutingTable> _mockRoutingTableMap; + private final List<String> _hybridTables; + + private final Map<String, Map<ServerInstance, List<String>>> _tableServerSegmentMap; + + public MockRoutingManagerFactory(int... ports) { + _hybridTables = new ArrayList<>(); + _serverInstances = new HashMap<>(); + _schemaMap = new HashMap<>(); + _tableNameMap = new HashMap<>(); + _mockRoutingTableMap = new HashMap<>(); + + _tableServerSegmentMap = new HashMap<>(); + for (int port : ports) { + _serverInstances.put(toHostname(port), new WorkerInstance(HOST_NAME, port, port, port, port)); + } + } + + public MockRoutingManagerFactory registerTable(Schema schema, String tableName) { + TableType tableType = TableNameBuilder.getTableTypeFromTableName(tableName); + if (tableType == null) { + registerTableNameWithType(schema, TableNameBuilder.forType(TableType.OFFLINE).tableNameWithType(tableName)); + registerTableNameWithType(schema, TableNameBuilder.forType(TableType.REALTIME).tableNameWithType(tableName)); + _hybridTables.add(tableName); + } else { + registerTableNameWithType(schema, TableNameBuilder.forType(tableType).tableNameWithType(tableName)); + } + return this; + } + + public MockRoutingManagerFactory registerSegment(int insertToServerPort, String tableNameWithType, + String segmentName) { + Map<ServerInstance, List<String>> serverSegmentMap = + _tableServerSegmentMap.getOrDefault(tableNameWithType, new HashMap<>()); + ServerInstance serverInstance = _serverInstances.get(toHostname(insertToServerPort)); + + List<String> sSegments = serverSegmentMap.getOrDefault(serverInstance, new ArrayList<>()); + sSegments.add(segmentName); + serverSegmentMap.put(serverInstance, sSegments); + _tableServerSegmentMap.put(tableNameWithType, serverSegmentMap); + return this; + } + + public RoutingManager buildRoutingManager() { + // create all the mock routing tables + _mockRoutingTableMap.clear(); + for (Map.Entry<String, Map<ServerInstance, List<String>>> tableEntry : _tableServerSegmentMap.entrySet()) { + String tableNameWithType = tableEntry.getKey(); + RoutingTable mockRoutingTable = mock(RoutingTable.class); + when(mockRoutingTable.getServerInstanceToSegmentsMap()).thenReturn(tableEntry.getValue()); + _mockRoutingTableMap.put(tableNameWithType, mockRoutingTable); + } + + // create the routing manager and the table cache + RoutingManager mock = mock(RoutingManager.class); + when(mock.getRoutingTable(any())).thenAnswer(invocation -> { Review Comment: nit: since we're mocking every method anyway - it's often better to just create a dedicated test implementation (Mocks are really supposed to be used in the top level class instead of in integration tests unless the mocked functionality is otherwise really complicated or you want to test unique scenarios) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For additional commands, e-mail: commits-h...@pinot.apache.org
