npawar commented on PR #9699: URL: https://github.com/apache/pinot/pull/9699#issuecomment-1301093871
> ### What does this PR do? > * add a Partial state in segment states > * change how we define segment status > > ### Issue > * GOOD and BAD status is very limiting to describe the segment status > * More often than not, Bad is just saying there's a mismatch between ideal state and external view, and not necessarily that the segment is in error state. > * When all replicas of a segment are offline, the Pinot UI still shows the segment is in good state. > > ### New Status definition > * if EV is empty then segment is missing servers - MISSING state (red) > * if EV contains ERROR state then segment is in Bad state (red) > * if EV status is CONSUMING or ONLINE then segment is in Good state (green) > * If EV state is OFFLINE and EV matches IS then segment is in Good state (green) > * If EV state is OFFLINE and EV does not matches IS then segment is in Partial state (orange). this often gets tagged as Bad, when it could just be that we're waiting to converge > > ### Screenshots > <img alt="image" width="720" src="https://user-images.githubusercontent.com/41536903/199576835-8423f078-7dbe-4b8a-9219-9d136528a7af.png"> > > ### Added tooltips to each status for more clarity/convenience > <img alt="image" width="250" src="https://user-images.githubusercontent.com/41536903/199546897-03e4eba2-af30-4c2e-b2ae-23b674b20915.png"> <img alt="image" width="305" src="https://user-images.githubusercontent.com/41536903/199546968-81cf47ea-3ea0-4b5b-b302-7254689e5add.png"> <img alt="image" width="224" src="https://user-images.githubusercontent.com/41536903/199547043-4d1c3870-9642-4484-a44f-051c3f43caad.png"> <img alt="image" width="298" src="https://user-images.githubusercontent.com/41536903/199576139-5eb0df63-e10a-428d-aaf7-ce80a324c6f2.png"> What is UNKNOWN? Also, we can combine MISSING and PARTIAL, both cases can be PARTIAL or WAITING TO CONVERGE, with tooltip "External view is OFFLINE or missing for one or more servers of this segment" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For additional commands, e-mail: commits-h...@pinot.apache.org