jadami10 commented on PR #9710: URL: https://github.com/apache/pinot/pull/9710#issuecomment-1300655618
this is awesome. How are you thinking about observability here? If you didn't expect the deep store data to be missing, but servers are just silently downloading segments from one another, how would you know? `Attempts exceeded when downloading segment` seems to be the only indicator. Maybe we need 2 new metrics for "download failed from deep store" vs "download failed from peer" and keep the current "download failed" as is to be used if both fail for backwards compatibility? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For additional commands, e-mail: commits-h...@pinot.apache.org
