chenboat commented on code in PR #9664:
URL: https://github.com/apache/pinot/pull/9664#discussion_r1006174221
##########
pinot-server/src/main/java/org/apache/pinot/server/api/resources/TablesResource.java:
##########
@@ -436,7 +436,8 @@ public Response downloadSegment(
public String uploadLLCSegment(
@ApiParam(value = "Name of the REALTIME table", required = true)
@PathParam("realtimeTableName")
String realtimeTableName,
- @ApiParam(value = "Name of the segment", required = true)
@PathParam("segmentName") String segmentName)
+ @ApiParam(value = "Name of the segment", required = true)
@PathParam("segmentName") String segmentName,
+ @ApiParam(value = "Whether to update hdfs url") @QueryParam("updateUrl")
boolean updateUrl)
Review Comment:
What is the default value here if users do not specify it? Can we make it
false explicitly?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
