lfernandez93 commented on code in PR #9556:
URL: https://github.com/apache/pinot/pull/9556#discussion_r995925707
##########
pinot-plugins/pinot-file-system/pinot-gcs/src/test/java/org/apache/pinot/plugin/filesystem/GcsPinotFSTest.java:
##########
@@ -92,7 +92,7 @@ public void setup() {
}
}
- @AfterClass
+ @AfterMethod
Review Comment:
hey, gladly, when done with @AfterClass this particular test was failing,
it's important to note that this test only runs if this is provided
https://github.com/apache/pinot/blob/9f92392b902fb9f25ce0af63bae9d925a4b9525b/pinot-plugins/pinot-file-system/pinot-gcs/src/test/java/org/apache/pinot/plugin/filesystem/GcsPinotFSTest.java#L84
given that I made changes around that class I was running this test, and I
found that because it was not getting cleaned up after every method this
assertion was failing
https://github.com/apache/pinot/blob/9f92392b902fb9f25ce0af63bae9d925a4b9525b/pinot-plugins/pinot-file-system/pinot-gcs/src/test/java/org/apache/pinot/plugin/filesystem/GcsPinotFSTest.java#L287
given that there are 2 files created by
https://github.com/apache/pinot/blob/9f92392b902fb9f25ce0af63bae9d925a4b9525b/pinot-plugins/pinot-file-system/pinot-gcs/src/test/java/org/apache/pinot/plugin/filesystem/GcsPinotFSTest.java#L156
that are not cleaned up.
So I decided to run the clean up after each test method is invoked.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
