siddharthteotia commented on code in PR #9333:
URL: https://github.com/apache/pinot/pull/9333#discussion_r988825619
##########
pinot-segment-local/src/main/java/org/apache/pinot/segment/local/segment/index/loader/defaultcolumn/BaseDefaultColumnHandler.java:
##########
@@ -372,6 +394,12 @@ protected boolean createColumnV1Indices(String column)
return false;
}
+ // TODO: Support forward index disabled derived column
+ if
(_indexLoadingConfig.getForwardIndexDisabledColumns().contains(column)) {
+ LOGGER.warn("Skip creating forward index disabled derived column:
{}", column);
Review Comment:
In this case it is to warn and not throw error since user asked for a
feature and we silently ignored (for now).
But in previous case, error should be thrown imo to tell user to change
derived column config's source column or refresh the segments first to generate
forward index on source column and then generate target derivedColumn
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
