zhtaoxiang commented on code in PR #9540:
URL: https://github.com/apache/pinot/pull/9540#discussion_r988424450
##########
pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/minion/PinotHelixTaskResourceManager.java:
##########
@@ -434,7 +434,7 @@ public synchronized Map<String, TaskPartitionState>
getSubtaskStates(String task
* @param taskName Task name
* @return List of child task configs
*/
- public synchronized List<PinotTaskConfig> getTaskConfigs(String taskName) {
+ public synchronized List<PinotTaskConfig> getSubtaskConfigs(String taskName)
{
Review Comment:
Could you please help me understand why we change the name? It seems to me
that Helix task is the right concept?
##########
pinot-controller/src/main/java/org/apache/pinot/controller/api/resources/PinotTaskRestletResource.java:
##########
@@ -386,7 +386,15 @@ public Map<String, TaskPartitionState> getSubtaskStates(
@ApiOperation("Get the task config (a list of child task configs) for the
given task")
public List<PinotTaskConfig> getTaskConfigs(
@ApiParam(value = "Task name", required = true) @PathParam("taskName")
String taskName) {
- return _pinotHelixTaskResourceManager.getTaskConfigs(taskName);
+ return _pinotHelixTaskResourceManager.getSubtaskConfigs(taskName);
+ }
+
+ @GET
+ @Path("/tasks/task/{taskName}/runtime/config")
+ @ApiOperation("Get the task runtime config for the given task")
+ public Map<String, String> getTaskConfig(
Review Comment:
just another thought: is it better to add a separate endpoint or is it
better to include more information in the existing endpoint?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
