walterddr commented on code in PR #9479:
URL: https://github.com/apache/pinot/pull/9479#discussion_r988364774
##########
pinot-core/src/main/java/org/apache/pinot/core/operator/blocks/InstanceResponseBlock.java:
##########
@@ -18,26 +18,71 @@
*/
package org.apache.pinot.core.operator.blocks;
-import org.apache.pinot.common.datatable.DataTable;
+import java.util.HashMap;
+import java.util.Map;
+import org.apache.pinot.common.response.ProcessingException;
import org.apache.pinot.core.common.Block;
import org.apache.pinot.core.common.BlockDocIdSet;
import org.apache.pinot.core.common.BlockDocIdValueSet;
import org.apache.pinot.core.common.BlockMetadata;
import org.apache.pinot.core.common.BlockValSet;
+import org.apache.pinot.core.operator.blocks.results.BaseResultsBlock;
+import org.apache.pinot.core.query.request.context.QueryContext;
/**
* InstanceResponseBlock is just a holder to get InstanceResponse from
InstanceResponseBlock.
*/
public class InstanceResponseBlock implements Block {
- private final DataTable _instanceResponseDataTable;
+ private final QueryContext _queryContext;
+ private final BaseResultsBlock _baseResultsBlock;
+ private final Map<String, String> _metadata;
+ private final Map<Integer, String> _exceptionMap;
- public InstanceResponseBlock(DataTable dataTable) {
- _instanceResponseDataTable = dataTable;
+ public InstanceResponseBlock(BaseResultsBlock baseResultsBlock, QueryContext
queryContext) {
+ this(baseResultsBlock, queryContext, baseResultsBlock.computeMetadata());
}
- public DataTable getInstanceResponseDataTable() {
- return _instanceResponseDataTable;
+ public InstanceResponseBlock(BaseResultsBlock baseResultsBlock, QueryContext
queryContext,
+ Map<String, String> metadata) {
+ _queryContext = queryContext;
+ _baseResultsBlock = baseResultsBlock;
+ _metadata = metadata;
+ _exceptionMap = new HashMap<>();
+ }
+
+ public InstanceResponseBlock(Map<String, String> metadata) {
+ _queryContext = null;
+ _baseResultsBlock = null;
+ _metadata = metadata;
+ _exceptionMap = new HashMap<>();
+ }
+
+ public InstanceResponseBlock() {
Review Comment:
technically no. it cannot be dangling
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
