jackjlli commented on code in PR #9390:
URL: https://github.com/apache/pinot/pull/9390#discussion_r977929089
##########
pinot-common/src/test/java/org/apache/pinot/common/data/FieldSpecTest.java:
##########
@@ -349,7 +349,7 @@ public void testSerializeDeserialize()
// Multi-value dimension field with default null value.
dimensionFields = new String[]{
"\"name\":\"dimension\"", "\"dataType\":\"STRING\"",
"\"singleValueField\":false",
- "\"defaultNullValue\":\"default\""
+ "\"defaultNullValue" + "\":\"default\""
Review Comment:
Same here.
##########
pinot-common/src/test/java/org/apache/pinot/common/data/FieldSpecTest.java:
##########
@@ -310,7 +310,7 @@ public void testOrderOfFields()
// Multi-value dimension field with default null value.
dimensionFields = new String[]{
"\"name\":\"dimension\"", "\"dataType\":\"STRING\"",
"\"singleValueField\":false",
- "\"defaultNullValue\":\"default\""
+ "\"defaultNullValue" + "\":\"default\""
Review Comment:
We may not need this change.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
