[GitHub] [pinot] npawar commented on a diff in pull request #9400: set MDC so that one can route minion task logs to separate files cleanly

[GitBox]

npawar commented on code in PR #9400:
URL: https://github.com/apache/pinot/pull/9400#discussion_r971425167


##########
pinot-tools/src/main/resources/log4j2.xml:
##########
@@ -39,6 +39,25 @@
       </Policies>
       <DefaultRolloverStrategy max="10"/>
     </RollingFile>
+    <Routing name="taskLogs" ignoreExceptions="false">
+      <Routes pattern="${ctx:taskId}">
+        <Route>
+          <RollingFile
+              name="minionTaskLogs-${ctx:taskId}"
+              
fileName="${env:LOG_ROOT}/minionTaskLogs-${ctx:taskId:-default}.log"
+              
filePattern="${env:LOG_ROOT}/minionTaskLogs-%d{yyyy-MM-dd}-%i.log"
+              immediateFlush="true">
+            <PatternLayout pattern="${env:LOG_PATTERN}"/>
+            <Policies>
+              <SizeBasedTriggeringPolicy size="19500KB"/>
+            </Policies>
+            <DefaultRolloverStrategy max="50"/>
+          </RollingFile>
+        </Route>
+      </Routes>
+      <!-- Created appender TTL -->
+      <IdlePurgePolicy timeToLive="15" timeUnit="minutes"/>

Review Comment:
   i understood the rollover if > 19.5MB or rollover if > 50 files. 
   What's the 15 minutes TTL? will that be enough? 
   Also is 50 max good enough? We could have a lot more tasks running at once 
rt?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org