yuanbenson commented on code in PR #9309:
URL: https://github.com/apache/pinot/pull/9309#discussion_r964213302
##########
pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/assignment/segment/BaseSegmentAssignment.java:
##########
@@ -185,7 +157,8 @@ protected Pair<List<Map<String, Map<String, String>>>,
Map<String, Map<String, S
* Rebalances segments in the current assignment using the
instancePartitions and returns new assignment
*/
protected Map<String, Map<String, String>> reassignSegments(String
instancePartitionType,
- Map<String, Map<String, String>> currentAssignment, InstancePartitions
instancePartitions, boolean bootstrap) {
+ Map<String, Map<String, String>> currentAssignment, InstancePartitions
instancePartitions, boolean bootstrap,
+ SegmentAssignmentStrategy segmentAssignmentStrategy,
InstancePartitionsType instancePartitionsType) {
Review Comment:
Seems a bit redundant to have both `String instancePartitionType` and
`InstancePartitionsType instancePartitionsType`, wondering if there's a way to
collapse these (however, seems like the first `String instancePartitionType` is
mixed with tier storage concept from before your change).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
