Jackie-Jiang commented on code in PR #9282:
URL: https://github.com/apache/pinot/pull/9282#discussion_r957828740
##########
pinot-core/src/main/java/org/apache/pinot/core/plan/maker/InstancePlanMakerImplV2.java:
##########
@@ -273,14 +273,13 @@ public Plan makeStreamingInstancePlan(List<IndexSegment>
indexSegments, QueryCon
if (QueryContextUtils.isSelectionOnlyQuery(queryContext)) {
// selection-only is streamed in StreamingSelectionPlanNode --> here
only metadata block is returned.
return new GlobalPlanImplV0(
- new InstanceResponsePlanNode(combinePlanNode, indexSegments,
Collections.emptyList(), queryContext,
- serverMetrics));
+ new InstanceResponsePlanNode(combinePlanNode, indexSegments,
Collections.emptyList(), queryContext));
} else {
// non-selection-only requires a StreamingInstanceResponsePlanNode to
stream data block back and metadata block
// as final return.
return new GlobalPlanImplV0(
- new StreamingInstanceResponsePlanNode(combinePlanNode,
indexSegments, Collections.emptyList(),
- streamObserver, queryContext, serverMetrics));
+ new StreamingInstanceResponsePlanNode(combinePlanNode,
indexSegments, Collections.emptyList(), queryContext,
+ streamObserver));
Review Comment:
Trying to keep it closer to the non-streaming one :-P
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
