sajjad-moradi commented on code in PR #9289:
URL: https://github.com/apache/pinot/pull/9289#discussion_r956621626
##########
pinot-controller/src/main/java/org/apache/pinot/controller/api/resources/PinotRealtimeTableResource.java:
##########
@@ -78,13 +79,21 @@ public Response pauseConsumption(
@Path("/tables/{tableName}/resumeConsumption")
@Produces(MediaType.APPLICATION_JSON)
@ApiOperation(value = "Resume consumption of a realtime table",
- notes = "Resume the consumption for a realtime table")
+ notes = "Resume the consumption for a realtime table. If offset criteria
is not provided, consumption continues "
+ + "based on the offsets in segment ZK metadata")
public Response resumeConsumption(
- @ApiParam(value = "Name of the table", required = true)
@PathParam("tableName") String tableName) {
+ @ApiParam(value = "Name of the table", required = true)
@PathParam("tableName") String tableName,
+ @ApiParam(value = "smallest | largest") @QueryParam("offsetCriteria")
String offsetCriteria) {
Review Comment:
👍 on `consumeFrom`. It reads better that way, but I prefer to keep
`smallest` and `largest` so the uri looks like:
`/tables/<tableName>/resumeConsumption?consumeFrom=smallest`
For the behavior of the `best` option you suggested, we currently achieve
that if `consumeFrom` parameter is not specified.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
