jadami10 commented on code in PR #9244:
URL: https://github.com/apache/pinot/pull/9244#discussion_r956377783
##########
pinot-spi/src/main/java/org/apache/pinot/spi/utils/CommonConstants.java:
##########
@@ -386,6 +386,15 @@ public static class Server {
"pinot.server.starter.enableRealtimeOffsetBasedConsumptionStatusChecker";
public static final boolean
DEFAULT_ENABLE_REALTIME_OFFSET_BASED_CONSUMPTION_STATUS_CHECKER = false;
+ public static final String
CONFIG_OF_ENABLE_REALTIME_FRESHNESS_BASED_CONSUMPTION_STATUS_CHECKER =
Review Comment:
If someone wants an orthogonal way to do this, then it's worth further
discussion there. The previous code was already doing something like this:
- if nothing is set, just start
- if realtime wait is set, wait a static amount of time before starting
- if offset is set, do nothing
- if offset and realtime wait is set, do the offset checker
At this point we've somewhat exhausted the "am I caught up" methods with
either freshness or offset based. If someone eventually wants something more
complex like "freshness and offset based together", we can migrate this config
to dynamically point to the class name of the offset checker they want.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
