siddharthteotia commented on code in PR #9274:
URL: https://github.com/apache/pinot/pull/9274#discussion_r954390590
##########
pinot-query-planner/src/test/java/org/apache/pinot/query/QueryEnvironmentTestBase.java:
##########
@@ -57,6 +57,8 @@ protected Object[][] provideQueries() {
+ " GROUP BY a.col1, a.col2"},
new Object[]{"SELECT a.col1, AVG(b.col3) FROM a JOIN b ON a.col1 =
b.col2 "
+ " WHERE a.col3 >= 0 AND a.col2 = 'a' AND b.col3 < 0 GROUP BY
a.col1"},
+ new Object[]{"SELECT a.col1, COUNT(*) FROM a WHERE a.col3 >= 0 AND
a.col2 = 'a' GROUP BY a.col1"
+ + " HAVING COUNT(*) > 10"},
Review Comment:
Suggest adding one test each for each supported comparison operator and may
be also include a different aggregation function
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
