jadami10 commented on code in PR #9244:
URL: https://github.com/apache/pinot/pull/9244#discussion_r953257958
##########
pinot-core/src/main/java/org/apache/pinot/core/data/manager/realtime/LLRealtimeSegmentDataManager.java:
##########
@@ -308,9 +308,9 @@ private boolean endCriteriaReached() {
_consumeEndTime +=
TimeUnit.HOURS.toMillis(TIME_EXTENSION_ON_EMPTY_SEGMENT_HOURS);
return false;
}
- _segmentLogger
- .info("Stopping consumption due to time limit start={} now={}
numRowsConsumed={} numRowsIndexed={}",
- _startTimeMs, now, _numRowsConsumed, _numRowsIndexed);
+ _segmentLogger.info(
Review Comment:
done
##########
pinot-server/src/main/java/org/apache/pinot/server/starter/helix/FreshnessBasedConsumptionStatusChecker.java:
##########
@@ -0,0 +1,102 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+package org.apache.pinot.server.starter.helix;
+
+import java.util.Set;
+import org.apache.pinot.core.data.manager.InstanceDataManager;
+import
org.apache.pinot.core.data.manager.realtime.LLRealtimeSegmentDataManager;
+import org.apache.pinot.segment.local.data.manager.SegmentDataManager;
+import org.apache.pinot.spi.stream.LongMsgOffset;
+import org.apache.pinot.spi.stream.StreamPartitionMsgOffset;
+
+
+/**
+ * This class is used at startup time to have a more accurate estimate of the
catchup period in which no query
+ * execution happens and consumers try to catch up to the latest messages
available in streams.
+ * To achieve this, every time status check is called - {@link
#getNumConsumingSegmentsNotReachedIngestionCriteria} -
+ * for each consuming segment, we check if either:
+ * - the segment's latest ingested offset has reached the current stream
offset that's
+ * - the last ingested message is within {@link #_minFreshnessMs} of the
current system time
+ */
+public class FreshnessBasedConsumptionStatusChecker extends
IngestionBasedConsumptionStatusChecker {
+ private final long _minFreshnessMs;
+
+ public FreshnessBasedConsumptionStatusChecker(InstanceDataManager
instanceDataManager, Set<String> consumingSegments,
+ long minFreshnessMs) {
+ super(instanceDataManager, consumingSegments);
+ _minFreshnessMs = minFreshnessMs;
+ }
+
+ private boolean isOffsetCaughtUp(StreamPartitionMsgOffset currentOffset,
StreamPartitionMsgOffset latestOffset) {
+ if (currentOffset != null && latestOffset != null) {
+ if (currentOffset.compareTo(latestOffset) == 0) {
+ return true;
+ }
+ if (currentOffset instanceof LongMsgOffset && latestOffset instanceof
LongMsgOffset) {
Review Comment:
I can't think of how else to do this even in the interface. This issue only
arises with Kafka because "latest offset" there is actually +1 of whatever your
current offset is. The kinesis and pulsar implementations use a string and
MessageId respectively to store the offset.
I can make a `getPreviousOffset` method in the
`LLRealtimeSegmentDataManager`, but then I just move this logic there.
I can put a `fetchPreviousOffset` in `StreamMetadataProvider`, but then I'll
just have to raise a `NotImplementedException` by default and later go update
our own custom `StreamMetadataProvider`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
