gviedma commented on code in PR #9258:
URL: https://github.com/apache/pinot/pull/9258#discussion_r951974277
##########
pinot-common/src/main/java/org/apache/pinot/common/metrics/ControllerGauge.java:
##########
@@ -110,7 +110,14 @@ public enum ControllerGauge implements
AbstractMetrics.Gauge {
MISSING_CONSUMING_SEGMENT_NEW_PARTITION_COUNT("missingConsumingSegmentNewPartitionCount",
false),
// Maximum duration of a missing consuming segment in ideal state (in
minutes)
-
MISSING_CONSUMING_SEGMENT_MAX_DURATION_MINUTES("missingSegmentsMaxDurationInMinutes",
false);
+
MISSING_CONSUMING_SEGMENT_MAX_DURATION_MINUTES("missingSegmentsMaxDurationInMinutes",
false),
+
+ // Number of in progress segment downloads
+
CONTROLLER_SEGMENT_DOWNLOADS_IN_PROGRESS_COUNT("segmentDownloadsInProgressCount",
true),
Review Comment:
Good point, I've dropped both the `CONTROLLER_` prefix and the `_COUNT`
suffix for readability.
I have also tagged the `segmentUpload` method in
`LLCSegmentCompletionHandlers` for tracking.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
