Jackie-Jiang commented on code in PR #9247:
URL: https://github.com/apache/pinot/pull/9247#discussion_r950548988
##########
pinot-broker/src/main/java/org/apache/pinot/broker/api/HttpRequesterIdentity.java:
##########
@@ -43,4 +45,31 @@ public String getEndpointUrl() {
public void setEndpointUrl(String endpointUrl) {
_endpointUrl = endpointUrl;
}
+
+ @Override
+ // If reverse proxy is used X-Forwarded-For will be populated
+ // If X-Forwarded-For is not present, check if x-real-ip is present
+ // Since X-Forwarded-For can contain comma separated list of values, we
convert it to ";" delimiter to avoid
+ // downstream parsing errors for other fields where "," is being used
Review Comment:
```suggestion
/**
* If reverse proxy is used X-Forwarded-For will be populated
* If X-Forwarded-For is not present, check if x-real-ip is present
* Since X-Forwarded-For can contain comma separated list of values, we
convert it to ";" delimiter to avoid
* downstream parsing errors for other fields where "," is being used
*/
@Override
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
