Jackie-Jiang commented on code in PR #9244:
URL: https://github.com/apache/pinot/pull/9244#discussion_r950412090
##########
pinot-spi/src/main/java/org/apache/pinot/spi/utils/CommonConstants.java:
##########
@@ -385,6 +385,13 @@ public static class Server {
"pinot.server.starter.enableRealtimeOffsetBasedConsumptionStatusChecker";
public static final boolean
DEFAULT_ENABLE_REALTIME_OFFSET_BASED_CONSUMPTION_STATUS_CHECKER = false;
+ public static final String
CONFIG_OF_ENABLE_REALTIME_FRESHNESS_BASED_CONSUMPTION_STATUS_CHECKER =
+
"pinot.server.starter.enableRealtimeFreshnessBasedConsumptionStatusChecker";
+ public static final boolean
DEFAULT_ENABLE_REALTIME_FRESHNESS_BASED_CONSUMPTION_STATUS_CHECKER = false;
+ public static final String CONFIG_OF_STARTUP_REALTIME_MIN_FRESHNESS_MS =
+ "pinot.server.starter.realtimeMinFreshnessMs";
+ public static final int DEFAULT_STARTUP_REALTIME_MIN_FRESHNESS_MS = 0;
Review Comment:
For a stream with high throughput, can this make it never able to catch up?
I think a higher default is better, e.g. 10s
##########
pinot-core/src/main/java/org/apache/pinot/core/data/manager/realtime/LLRealtimeSegmentDataManager.java:
##########
@@ -1440,6 +1440,17 @@ private void fetchLatestStreamOffset() {
}
}
+ public StreamPartitionMsgOffset fetchLatestStreamOffset(Long maxWaitTimeMs) {
Review Comment:
(minor)
```suggestion
public StreamPartitionMsgOffset fetchLatestStreamOffset(long
maxWaitTimeMs) {
```
##########
pinot-server/src/main/java/org/apache/pinot/server/starter/helix/FreshnessBasedConsumptionStatusChecker.java:
##########
@@ -0,0 +1,154 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+package org.apache.pinot.server.starter.helix;
+
+import java.util.HashSet;
+import java.util.Set;
+import org.apache.pinot.common.utils.LLCSegmentName;
+import org.apache.pinot.core.data.manager.InstanceDataManager;
+import
org.apache.pinot.core.data.manager.realtime.LLRealtimeSegmentDataManager;
+import org.apache.pinot.segment.local.data.manager.SegmentDataManager;
+import org.apache.pinot.segment.local.data.manager.TableDataManager;
+import org.apache.pinot.spi.config.table.TableType;
+import org.apache.pinot.spi.stream.LongMsgOffset;
+import org.apache.pinot.spi.stream.StreamPartitionMsgOffset;
+import org.apache.pinot.spi.utils.builder.TableNameBuilder;
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
+
+
+/**
+ * This class is used at startup time to have a more accurate estimate of the
catchup period in which no query execution
+ * happens and consumers try to catch up to the latest messages available in
streams.
+ * To achieve this, every time status check is called - {@link
#getNumConsumingSegmentsNotReachedMinFreshness} -
+ * for each consuming segment, we check if either:
+ * - the segment's latest ingested offset has reached the current stream
offset that's
+ * - the last ingested message is within {@link #_minFreshnessMs} of the
current system time
+ */
+public class FreshnessBasedConsumptionStatusChecker {
+ private static final Logger LOGGER =
LoggerFactory.getLogger(FreshnessBasedConsumptionStatusChecker.class);
+
+ // constructor parameters
+ private final InstanceDataManager _instanceDataManager;
+ private final Set<String> _consumingSegments;
+ private final Long _minFreshnessMs;
Review Comment:
(minor) Same for other boxed `Long`
```suggestion
private final long _minFreshnessMs;
```
##########
pinot-core/src/main/java/org/apache/pinot/core/data/manager/realtime/LLRealtimeSegmentDataManager.java:
##########
@@ -1440,6 +1440,17 @@ private void fetchLatestStreamOffset() {
}
}
+ public StreamPartitionMsgOffset fetchLatestStreamOffset(Long maxWaitTimeMs) {
+ try (StreamMetadataProvider metadataProvider = _streamConsumerFactory
+ .createPartitionMetadataProvider(_clientId, _partitionGroupId)) {
+ return
metadataProvider.fetchStreamPartitionOffset(OffsetCriteria.LARGEST_OFFSET_CRITERIA,
maxWaitTimeMs);
+ } catch (Exception e) {
+ _segmentLogger.warn("Cannot fetch latest stream offset for clientId {}
and partitionGroupId {}", _clientId,
Review Comment:
Let's also log the `maxWaitTime`
##########
pinot-core/src/main/java/org/apache/pinot/core/data/manager/realtime/LLRealtimeSegmentDataManager.java:
##########
@@ -1440,6 +1440,17 @@ private void fetchLatestStreamOffset() {
}
}
+ public StreamPartitionMsgOffset fetchLatestStreamOffset(Long maxWaitTimeMs) {
Review Comment:
Seems we are always using 5s as the wait time. So we should either:
1. Make `fetchLatestStreamOffset()` public and use it
2. Remove `fetchLatestStreamOffset()`, and add a `DEFAULT_MAX_WAIT_TIME_MS`
constant
##########
pinot-server/src/main/java/org/apache/pinot/server/starter/helix/FreshnessBasedConsumptionStatusChecker.java:
##########
@@ -0,0 +1,154 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+package org.apache.pinot.server.starter.helix;
+
+import java.util.HashSet;
+import java.util.Set;
+import org.apache.pinot.common.utils.LLCSegmentName;
+import org.apache.pinot.core.data.manager.InstanceDataManager;
+import
org.apache.pinot.core.data.manager.realtime.LLRealtimeSegmentDataManager;
+import org.apache.pinot.segment.local.data.manager.SegmentDataManager;
+import org.apache.pinot.segment.local.data.manager.TableDataManager;
+import org.apache.pinot.spi.config.table.TableType;
+import org.apache.pinot.spi.stream.LongMsgOffset;
+import org.apache.pinot.spi.stream.StreamPartitionMsgOffset;
+import org.apache.pinot.spi.utils.builder.TableNameBuilder;
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
+
+
+/**
+ * This class is used at startup time to have a more accurate estimate of the
catchup period in which no query execution
+ * happens and consumers try to catch up to the latest messages available in
streams.
+ * To achieve this, every time status check is called - {@link
#getNumConsumingSegmentsNotReachedMinFreshness} -
+ * for each consuming segment, we check if either:
+ * - the segment's latest ingested offset has reached the current stream
offset that's
+ * - the last ingested message is within {@link #_minFreshnessMs} of the
current system time
+ */
+public class FreshnessBasedConsumptionStatusChecker {
+ private static final Logger LOGGER =
LoggerFactory.getLogger(FreshnessBasedConsumptionStatusChecker.class);
+
+ // constructor parameters
+ private final InstanceDataManager _instanceDataManager;
+ private final Set<String> _consumingSegments;
+ private final Long _minFreshnessMs;
+
+ // helper variable
+ private final Set<String> _caughtUpSegments = new HashSet<>();
+
+ public FreshnessBasedConsumptionStatusChecker(InstanceDataManager
instanceDataManager, Set<String> consumingSegments,
+ Long minFreshnessMs) {
+ _instanceDataManager = instanceDataManager;
+ _consumingSegments = consumingSegments;
+ _minFreshnessMs = minFreshnessMs;
+ }
+
+ private boolean isOffsetCaughtUp(StreamPartitionMsgOffset currentOffset,
StreamPartitionMsgOffset latestOffset) {
+ if (currentOffset != null && latestOffset != null) {
+ if (currentOffset.compareTo(latestOffset) == 0) {
+ return true;
+ }
+ long currentOffsetLong = ((LongMsgOffset) currentOffset).getOffset();
+ long latestOffsetLong = ((LongMsgOffset) latestOffset).getOffset();
+ // Kafka's "latest" offset is actually the next available offset.
Therefore it will be 1 ahead of the
+ // current offset in the case we are caught up.
+ // We expect currentOffset == latestOffset if no messages have ever been
published. Both will be 0.
+ // Otherwise, we never expect currentOffset > latestOffset, but we allow
this to be caught up in case
+ // it ever happens so we're not stuck starting up.
+ return currentOffsetLong >= latestOffsetLong - 1;
+ }
+ return false;
+ }
+
+ protected Long now() {
+ return System.currentTimeMillis();
+ }
+
+ public int getNumConsumingSegmentsNotReachedMinFreshness() {
+ for (String segName : _consumingSegments) {
+ if (_caughtUpSegments.contains(segName)) {
+ continue;
+ }
+ TableDataManager tableDataManager = getTableDataManager(segName);
+ if (tableDataManager == null) {
+ LOGGER.info("TableDataManager is not yet setup for segment {}. Will
check consumption status later", segName);
+ continue;
+ }
+ SegmentDataManager segmentDataManager = null;
+ try {
+ segmentDataManager = tableDataManager.acquireSegment(segName);
+ if (segmentDataManager == null) {
+ LOGGER.info("SegmentDataManager is not yet setup for segment {}.
Will check consumption status later",
+ segName);
+ continue;
+ }
+ if (!(segmentDataManager instanceof LLRealtimeSegmentDataManager)) {
+ // There's a possibility that a consuming segment has converted to a
committed segment. If that's the case,
+ // segment data manager will not be of type LLRealtime.
+ LOGGER.info("Segment {} is already committed and is considered
caught up.", segName);
+ _caughtUpSegments.add(segName);
+ continue;
+ }
+ LLRealtimeSegmentDataManager rtSegmentDataManager =
(LLRealtimeSegmentDataManager) segmentDataManager;
+ Long now = now();
Review Comment:
(minor) Change boxed `Long` to primitive, same for other places
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
