sajjad-moradi commented on code in PR #9228:
URL: https://github.com/apache/pinot/pull/9228#discussion_r948461730
##########
pinot-controller/src/main/java/org/apache/pinot/controller/api/access/AccessControlUtils.java:
##########
@@ -100,11 +91,15 @@ public void validatePermission(Optional<String>
tableNameOpt, AccessType accessT
* @param httpHeaders HTTP headers containing requester identity required by
access control object
Review Comment:
Update the javadoc. It's not a table level.
##########
pinot-controller/src/main/java/org/apache/pinot/controller/api/access/AccessControlUtils.java:
##########
@@ -43,55 +48,41 @@ public class AccessControlUtils {
* @param endpointUrl the request url for which this access control is called
* @param accessControl AccessControl object which does the actual validation
*/
- public void validatePermission(String tableName, AccessType accessType,
HttpHeaders httpHeaders, String endpointUrl,
- AccessControl accessControl) {
- validatePermission(Optional.of(tableName), accessType, httpHeaders,
endpointUrl, accessControl);
- }
+ public static void validatePermission(@Nullable String tableName, AccessType
accessType,
+ @Nullable HttpHeaders httpHeaders, @Nullable String endpointUrl,
AccessControl accessControl) {
+ String accessTypeToEndpointMsg =
+ String.format("access type '%s' to the endpoint '%s' for table '%s'",
accessType, endpointUrl, tableName);
Review Comment:
If tableName is null, the log message doesn't look good. Previous message
was handling this case better IMO.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
