Jackie-Jiang commented on code in PR #9197:
URL: https://github.com/apache/pinot/pull/9197#discussion_r946206230
##########
pinot-controller/src/main/java/org/apache/pinot/controller/api/resources/PinotRealtimeTableResource.java:
##########
@@ -90,6 +90,23 @@ public Response resumeConsumption(
}
}
+ @POST
+ @Path("/tables/{tableName}/resetConsumption")
Review Comment:
Suggest making the API more explicit that it is just force committing the
consuming segment. Something like `POST /tables/{tableName}/forceCommit`
##########
pinot-controller/src/main/java/org/apache/pinot/controller/api/resources/PinotRealtimeTableResource.java:
##########
@@ -90,6 +90,23 @@ public Response resumeConsumption(
}
}
+ @POST
+ @Path("/tables/{tableName}/resetConsumption")
+ @ApiOperation(value = "Reset consumption of a realtime table",
+ notes = "Reset the consumption for a realtime table using force commit")
+ public Response resetConsumption(
+ @ApiParam(value = "Name of the table", required = true)
@PathParam("tableName") String tableName) {
Review Comment:
Suggest adding an optional segment so that we only force commit one segment?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
