klsince commented on code in PR #9171:
URL: https://github.com/apache/pinot/pull/9171#discussion_r946121455
##########
pinot-broker/src/main/java/org/apache/pinot/broker/requesthandler/BaseBrokerRequestHandler.java:
##########
@@ -190,7 +259,17 @@ public BrokerResponseNative handleRequest(JsonNode
request, @Nullable RequesterI
if (sql == null) {
throw new BadQueryRequestException("Failed to find 'sql' in the request:
" + request);
}
- return handleRequest(requestId, sql.asText(), request, requesterIdentity,
requestContext);
+ if (!_enableQueryCancellation) {
+ return handleRequest(requestId, sql.asText(), request,
requesterIdentity, requestContext);
+ }
+ _queriesById.put(requestId, new QueryRoutingTable(sql.asText()));
Review Comment:
moved inside the handleRequest() just before sending the queries out to
servers, to avoid the potential failures that could happen before sending the
query out to servers.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
