[GitHub] [pinot] nizarhejazi commented on a diff in pull request #9173: Proper null handling in equality, inequality and membership operators for all SV column data types

[GitBox]

nizarhejazi commented on code in PR #9173:
URL: https://github.com/apache/pinot/pull/9173#discussion_r939439025


##########
pinot-core/src/main/java/org/apache/pinot/core/operator/filter/predicate/PredicateUtils.java:
##########
@@ -76,7 +76,7 @@ public static IntSet getDictIdSet(BaseInPredicate 
inPredicate, Dictionary dictio
     IntSet dictIdSet = new IntOpenHashSet(hashSetSize);
     switch (dataType.getStoredType()) {
       case INT:
-        int[] intValues = inPredicate.getIntValues();
+        int[] intValues = dataType == DataType.BOOLEAN ? 
inPredicate.getBooleanValues() : inPredicate.getIntValues();

Review Comment:
   @Jackie-Jiang I'd rather fix it here since we use membership operators `IN 
(value, value)` in many of our queries. 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org