saurabhd336 commented on code in PR #8828:
URL: https://github.com/apache/pinot/pull/8828#discussion_r930662579


##########
pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/PinotHelixResourceManager.java:
##########
@@ -1984,6 +1987,82 @@ private Set<String> getAllInstancesForTable(String 
tableNameWithType) {
     return instanceSet;
   }
 
+  public Map<String, String> getControllerJobZKMetadata(String taskId) {
+    String controllerJobResourcePath = 
ZKMetadataProvider.constructPropertyStorePathForControllerJob();
+    if (_propertyStore.exists(controllerJobResourcePath, 
AccessOption.PERSISTENT)) {
+      ZNRecord taskResourceZnRecord = 
_propertyStore.get(controllerJobResourcePath, null, -1);

Review Comment:
   Helix may throw a ZkNoNodeException exception if options = -1. So I've 
handled that



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org

Reply via email to