[GitHub] [pinot] Jackie-Jiang commented on a diff in pull request #9105: Fail spark application in case of no input files

[GitBox]

Jackie-Jiang commented on code in PR #9105:
URL: https://github.com/apache/pinot/pull/9105#discussion_r930239005


##########
pinot-plugins/pinot-batch-ingestion/pinot-batch-ingestion-spark-2.4/src/main/java/org/apache/pinot/plugin/ingestion/batch/spark/SparkSegmentGenerationJobRunner.java:
##########
@@ -191,6 +191,13 @@ public void run()
       }
     }
 
+    if (filteredFiles.isEmpty()) {
+      throw new RuntimeException(
+          String.format("No files found in the input directory %s matching 
includeFileNamePattern: %s,"

Review Comment:
   (nit)
   ```suggestion
             String.format("No file found in the input directory: %s matching 
includeFileNamePattern: %s,"
   ```



##########
pinot-plugins/pinot-batch-ingestion/pinot-batch-ingestion-spark-3.2/src/main/java/org/apache/pinot/plugin/ingestion/batch/spark3/SparkSegmentGenerationJobRunner.java:
##########
@@ -191,6 +191,13 @@ public void run()
       }
     }
 
+    if (filteredFiles.isEmpty()) {
+      throw new RuntimeException(
+          String.format("No files found in the input directory %s matching 
includeFileNamePattern: %s,"

Review Comment:
   (nit)
   ```suggestion
             String.format("No file found in the input directory: %s matching 
includeFileNamePattern: %s,"
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org